Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ember-CLI and add tests/dummy/public #50

Merged
merged 7 commits into from Dec 19, 2017
Merged

Update Ember-CLI and add tests/dummy/public #50

merged 7 commits into from Dec 19, 2017

Commits on Dec 13, 2017

  1. Update Ember-CLI and add tests/dummy/public 

    I updated to Ember-CLI 2.17.1 and ran the related blueprints.

I also, I think have a partial solution for #29

I added a check in src/index.js like:

```js
if(isAddon) {
  defaultOpts.sourceDirs.push('tests/dummy/public');
  }
```

So we should be automatically adding `tests/dummy/public` to the directories we look through, if you are inside an addon.

I tried linking locally to an addon to test, but when I ran `ember s` the addon could not access http://localhost:4200/ember-svg-jar/index.html so I am not 100% sure if this works or not, but I think it should.
    @RobbieTheWagner
    RobbieTheWagner committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    b8731d8 View commit details
    Browse the repository at this point in the history

  2. Fix lint issues

    @RobbieTheWagner
    RobbieTheWagner committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    6dc6d7a View commit details
    Browse the repository at this point in the history

  3. Try adding useYarn

    @RobbieTheWagner
    RobbieTheWagner committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    af7d102 View commit details
    Browse the repository at this point in the history

  4. Add explicit scenarios for ember-try

    @RobbieTheWagner
    RobbieTheWagner committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    db00deb View commit details
    Browse the repository at this point in the history

  5. Update .travis.yml

    @RobbieTheWagner
    RobbieTheWagner committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    98b8003 View commit details
    Browse the repository at this point in the history

  6. Update ember-try.js

    @RobbieTheWagner
    RobbieTheWagner committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    056f323 View commit details
    Browse the repository at this point in the history

  7. Update package.json

    @RobbieTheWagner
    RobbieTheWagner committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    79cf922 View commit details
    Browse the repository at this point in the history