Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better addon support #52

Merged
merged 1 commit into from Jan 28, 2018
Merged

Better addon support #52

merged 1 commit into from Jan 28, 2018

Commits on Jan 11, 2018

  1. Better addon support 

    This change allows ember-svg-jar to be used by addons. [Recent work](evoactivity#29) also mentioned making it work in addons, but that only makes it work within an addon's own dummy app, when consumed as a `devDependency`.

This change makes ember-svg-jar work as a `dependency`. Multiple addons and/or the top-level app can all use it simultaneously without stomping each other (with the one caveat that the namespace of SVG asset ids is flat, so `{{svg-jar "something"}}` has a consistency meaning no matter where it appears.

I only implemented this for the default, inline strategy. It would be possible in the future to do for the symbol strategy.
    @ef4
    ef4 committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    5725b76 View commit details
    Browse the repository at this point in the history