Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes needed for gradle 3.0.1 compatibility #750

Open
pacamara opened this issue Jan 19, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@pacamara
Copy link

commented Jan 19, 2018

Some minor changes are needed for gradle 3.0.1 compatibility: in android/build.gradle:

We are currently hacking these changes with a script in status.im, and would rather it is fixed upstream. Thanks!

Parent issue: status-im/status-react#3037

Using react-native version 0.51.0, react-native-fcm version 10.0.3 (but problem still exists in your latest version v11.3.0).

@evollu

This comment has been minimized.

Copy link
Owner

commented Jan 20, 2018

PR is welcomed.
Is this backward compatible?

@pacamara

This comment has been minimized.

Copy link
Author

commented Jan 25, 2018

@evollu Indeed there are compatbility issues... we now realize doing this is a breaking change for new projects created with react-native init, unless these manual changes are made to the generated project. So we are going to wait for react-native to upgrade to gradle 3. Thanks!

@evollu

This comment has been minimized.

Copy link
Owner

commented Jan 25, 2018

cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.