Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android compilation warnings #3037

Closed
jeluard opened this issue Jan 15, 2018 · 2 comments · Fixed by #3086
Closed

Fix android compilation warnings #3037

jeluard opened this issue Jan 15, 2018 · 2 comments · Fixed by #3086

Comments

@jeluard
Copy link
Contributor

jeluard commented Jan 15, 2018

User Story

As a developer, I don't want warnings when running commands.

Description

Type: Bug

Running react-native run-android generates a bunch of warnings. We want to remove as much as possible.

Examples of warnings:

Configuration 'compile' in project ':app' is deprecated. Use 'implementation' instead.
registerResGeneratingTask is deprecated, use registerGeneratedFolders(FileCollection)
registerResGeneratingTask is deprecated, use registerGeneratedFolders(FileCollection)

Configuration 'compile' in project ':react-native-splash-screen' is deprecated. Use 'implementation' instead.
Configuration 'testCompile' in project ':react-native-splash-screen' is deprecated. Use 'testImplementation' instead.
WARNING: The specified Android SDK Build Tools version (25.0.3) is ignored, as it is below the minimum supported version (26.0.2) for Android Gradle Plugin 3.0.1.
Android SDK Build Tools 26.0.2 will be used.
To suppress this warning, remove "buildToolsVersion '25.0.3'" from your build.gradle file, as each version of the Android Gradle Plugin now has a default version of the build tools.

/home/julien/Documents/Projects/status-react/android/app/src/main/AndroidManifest.xml:23:5-87 Warning:
        uses-permission#android.permission.BLUETOOTH was tagged at AndroidManifest.xml:23 to remove other declarations but no other declaration present
/home/julien/Documents/Projects/status-react/android/app/src/main/AndroidManifest.xml:25:5-92 Warning:
        uses-permission#android.permission.WRITE_CONTACTS was tagged at AndroidManifest.xml:25 to remove other declarations but no other declaration present
/home/julien/Documents/Projects/status-react/android/app/src/main/AndroidManifest.xml:28:5-90 Warning:
        uses-permission#android.permission.RECORD_VIDEO was tagged at AndroidManifest.xml:28 to remove other declarations but no other declaration present

> Task :app:hemroidBuild
/home/julien/Android/Sdk/ndk-bundle/build/core/setup-app.mk:81: Android NDK: Application targets deprecated ABI(s): mips64 armeabi mips    
/home/julien/Android/Sdk/ndk-bundle/build/core/setup-app.mk:82: Android NDK: Support for these ABIs will be removed in a future NDK release.  

Some might be related to our dependencies: in this case we must create issues in relevant project if needed.

@status-open-bounty
Copy link

status-open-bounty commented Jan 16, 2018

Balance: 0.000000 ETH
Tokens: SNT: 800.00
Contract address: 0x60310d20f9c628ee7028ce05310b6667e193a4cc
Network: Mainnet
Paid to: pacamara
Visit https://openbounty.status.im to learn more.

@andytudhope andytudhope moved this from bounty-awaiting-approval to Bounty Open in Status Bounty Tracker Jan 16, 2018
@pacamara
Copy link
Contributor

@jeluard Have pushed a fix which removes nearly all the warnings, and explains what/why for the remaining ones: #3086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status Bounty Tracker
  
Merged & Confirmed
Development

Successfully merging a pull request may close this issue.

4 participants