Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable key length limits if SHA function will be used #6

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

arixmkii
Copy link
Contributor

@arixmkii arixmkii commented Feb 12, 2019

  • Allowing keys longer than 16 symbols if SHA function is used

    • If SHA function is used, then there is no requirement to limit key length (similar as with well known PBE implementations).
  • Bugfixes

    • v1 code was written to not use IV, but opted for CTR. This is like impossible combination, the only path without IV is ECB. So, it was changed to ECB with padding "aka" default "AES". There was no sample of old value, so, the choice of ECB with padding default is a guess.
  • New tests

    • For longer keys input.
    • For verifying that IV allows to generate different encoded values with every call.
  • Backward compatibility tests

    • For restored v1 decryption and v0 decryption (encrypted values generated with reverse engineering).

Added backward compatibility tests.
Bugfixes.
@coveralls
Copy link

Coverage Status

Coverage increased (+19.3%) to 76.471% when pulling 15f9be2 on arixmkii:longer_key_support into 8224045 on evolution-gaming:master.

@mikla
Copy link

mikla commented Mar 27, 2019

@t3hnar could you please have a look? It hangs open for a month+ already.

@t3hnar t3hnar merged commit 41a3b70 into evolution-gaming:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants