-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix release race conditions and refactor core flows #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3hnar
suggested changes
May 21, 2023
t3hnar
reviewed
May 22, 2023
t3hnar
reviewed
May 22, 2023
i-surkov
force-pushed
the
isurkov/fixed-release-race-conditions
branch
from
May 22, 2023 14:21
694dce9
to
643cfff
Compare
t3hnar
suggested changes
May 22, 2023
Changed semantics as discussed with @t3hnar:
|
t3hnar
suggested changes
May 23, 2023
t3hnar
suggested changes
May 23, 2023
t3hnar
suggested changes
May 24, 2023
t3hnar
suggested changes
May 25, 2023
t3hnar
approved these changes
May 25, 2023
i-surkov
changed the title
Fix release race conditions
Fix release race conditions and refactor core flows
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test specs added demonstrate race conditions when performing
release
of values under the same key, when there are multiple concurrentgetOrUpdate1
,put
, andremove
operations being performed. Two of these specs (put
+remove
, andgetOrUpdate1
+put
+remove
) fail on the current master branch.In short, there were several mix-ups as to which fiber should release which entry and in which case: some entries were being abandoned and not released after being removed, and for some, release was being performed more than once.