Implement modify #202
Merged
Implement modify #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3hnar
suggested changes
May 30, 2023
t3hnar
suggested changes
May 31, 2023
t3hnar
approved these changes
Jun 1, 2023
i-surkov
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Initial modify implementation * Implement tests and allow use in fenced * Remove outdated comments * Modify returns old value release handle, add modification sequencing tests * Renamed things as per PR review * Add helper extension methods and comments. * Further refactoring --------- Co-authored-by: Ilya Surkov <isurkov@evolution.com> (cherry picked from commit f43cf2a)
i-surkov
added a commit
that referenced
this pull request
Jun 7, 2023
* Initial modify implementation * Implement tests and allow use in fenced * Remove outdated comments * Modify returns old value release handle, add modification sequencing tests * Renamed things as per PR review * Add helper extension methods and comments. * Further refactoring --------- Co-authored-by: Ilya Surkov <isurkov@evolution.com> (cherry picked from commit f43cf2a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.