Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce usages of Blocking #232

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Reduce usages of Blocking #232

merged 1 commit into from
Jan 26, 2022

Conversation

Z1kkurat
Copy link
Contributor

No description provided.

@Z1kkurat Z1kkurat requested a review from t3hnar January 26, 2022 13:39
@coveralls
Copy link

coveralls commented Jan 26, 2022

Pull Request Test Coverage Report for Build 1751062332

  • 15 of 19 (78.95%) changed or added relevant lines in 6 files are covered.
  • 7 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.6%) to 84.847%

Changes Missing Coverage Covered Lines Changed/Added Lines %
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/Consumer.scala 6 7 85.71%
skafka/src/main/scala/com/evolutiongaming/skafka/producer/ProducerOf.scala 1 2 50.0%
skafka/src/main/scala/com/evolutiongaming/skafka/producer/Producer.scala 4 6 66.67%
Files with Coverage Reduction New Missed Lines %
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerConverters.scala 1 95.08%
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetrics.scala 1 94.44%
skafka/src/main/scala/com/evolutiongaming/skafka/producer/ProducerConfig.scala 1 84.93%
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/Consumer.scala 4 81.97%
Totals Coverage Status
Change from base Build 1698943399: -0.6%
Covered Lines: 1299
Relevant Lines: 1531

💛 - Coveralls

@Z1kkurat Z1kkurat merged commit 5c311c4 into master Jan 26, 2022
@Z1kkurat Z1kkurat deleted the feature/reduce-blocking-usage branch January 26, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants