-
-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make AccessToken, RefreshToken and Grant models swappable. #467
Conversation
I started a clean branch after the original got abandoned. #347 |
At first glance it looks a ton better than before. I think this will be mergeable. I'll try to find some time to review this. but I'm a bit short on it right now. @clintonb wanna help? |
@jleclanche I added more test cases, updated docs and cleaned a bit. Please let me know any questions or suggestions you might have. hi @clintonb |
This is great, but it'll take me a while to get to it and review. It definitely looks landable though, we can get this in for next version. |
This PR #252 is also related to this. I didn't know this was a 3rd attempt to get this feature. |
@jleclanche I just updated this to with the latest changes merge into master |
@menecio can you rebase it instead of merge? This still has conflicts as-is. |
… directly from models
…st of abstract models.
…e anymore since it refers to %(app_label)s_%(class)s from the swapped model, tokens must be queried by filtering on get_access_token_model() and use request.user
…hToken are now swappable.
…ct and wnen not installed.
3 similar comments
@jleclanche Done. Let me know if there is something else. Thank you very much for your time. |
hey @clintonb I'll ping you to see if you have some time to check this one out. @jleclanche seems to be quite busy. Thanks |
Apologies, fell through the crack. Reviewing now. |
@menecio Landed in master with some minor cleanups. And I just want to thank you for this PR. Not only is it a feature that's been long requested in DOT, but you implemented it cleanly, pushed out well-separated commits, made it really easy to review and just generally kept it high quality. In 10 years of using Github, I can count on one hand the amount of times I've seen this happen for drive-by PRs :) |
Thank you @coveralls! @jleclanche or @clintonb are there any plans to release this to pypi in the near future? |
I'm just an interested party, not a maintainer. I have not ability to
release.
--
Clinton
|
Yeah I can't do releases either. |
Sorry to have bothered you guys! It looks like maybe it's @synasius that can do a release? |
It would be nice to have some feedback from @synasius about a possible release of this. |
The release happened a while ago. |
Ok, I was using a previous release. Shame on me |
Make it possible to use custom models for access tokens, refresh tokens and grants.