Skip to content
This repository has been archived by the owner on Feb 28, 2020. It is now read-only.

Tag interface on message object does not match django.contrib.messages #21

Open
nthall opened this issue Jan 4, 2016 · 2 comments
Open

Comments

@nthall
Copy link

nthall commented Jan 4, 2016

Tag storage & retrieval in this module does not match the way tags are handled in django.contrib.messages. In the built-in module, the tags property is derived by prepending a string based on the message level to the list of extra_tags. Here, no message level tag is added, and extra_tags simply becomes tags. Additionally, the builtin Message object exposes the level_tag (string representation of message level) as a standalone property.

I'm working in python 2.7.10, django 1.8.1 on ubuntu 15.10.

I'm hoping to submit a PR fixing this when I have the chance.

@joej
Copy link

joej commented Mar 11, 2018

This is a 2016 fix that is still open?

@nthall
Copy link
Author

nthall commented Mar 16, 2018

yes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants