-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InexactError: trunc(UInt8, 256) when user sets nbins>255 #222
Comments
MWE (taken from the example in docs):
Tested on the latest version in main.
|
Adding domain validation of the arguments passed to the hyper-params constructors is something I've been shoveling forward a bit too long! Thanks for reporting, feel free to go for a PR, otherwise, I'll likely get it done with 1-2 days. |
I have too many other things going on this weekend, but I should be able to get to it on Monday. When I find time, I'll check here if you've started or not. |
I've hacked up a draft. Let me know what you think! |
Current behaviour: If a user sets
nbins>255
they will getInexactError: trunc(UInt8, 256)
Expected behaviour: Either the restriction should be explicit and caught on initialization or the code should be updated.
Possible cause:
binarize
UInt8
, so implicitly assuming there are never more than 255 binsSuggested solution:
I'm happy to take a stab at the PR if helpful.
The text was updated successfully, but these errors were encountered: