Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pass the copyright notice to the generated file #121

Merged
merged 1 commit into from Dec 23, 2019
Merged

Do not pass the copyright notice to the generated file #121

merged 1 commit into from Dec 23, 2019

Conversation

jacekkow
Copy link
Contributor

While the template itself is copyright-protected, I would not consider the generated config file a Derivative Work, therefore (as far as I know) it should not contain the Apache license template.

Copy link
Owner

@evrardjp evrardjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fair.

I will have to sync with people for releasing this, as it will effectively change their configuration, and trigger a restart. I can't merge it like this, as it will impact all production users. But I agree that I should remove this, nobody cares about seeing that it's an apache thing, or that my name stands on that :p

@evrardjp
Copy link
Owner

Are you in a hurry to merge this? Because I will need to sync with people, and it's holiday period right now.

@jacekkow
Copy link
Contributor Author

Take your time. I also see a possibility of adding an option whether to add this template or not (default set to not impact existing users).

@evrardjp
Copy link
Owner

I don't want to bloat the role of variables :)

At first sight, people are okay with it. Let's merge this after the holiday period... I will tag the other two patches in a release before that if you're in hurry.

My responses are relatively slow nowadays, because I am on vacation myself, sorry for the delays.

@evrardjp evrardjp merged commit 9e7a079 into evrardjp:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants