Decrease TCP retries in case of VIP failover #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Um, where is CI? |
|
That's weird. It's supposed to be github actions. |
|
FYI that solution is unverified :) I can see why we want to reduce it, but 3 is really agressive. Should we move down to 8? 6? I think that below is very agressive. We might want to introduce a variable for the brave people out there :) |
noonedeadpunk
force-pushed
the
tcp_retries
branch
from
189c6f1
to
b260610
Compare
|
This is on hold until #169 is confirmed working (fixing CI). |
In case of VIP failover some connections (like mysql) can stuck in retrying to connect and detect a dead connection. We should probably make this failover to be detected faster then the default value as suggested in [1] [1] https://access.redhat.com/solutions/726753 Related-Bug: https://bugs.launchpad.net/kolla-ansible/+bug/1917068
noonedeadpunk
force-pushed
the
tcp_retries
branch
from
b260610
to
4b3d64f
Compare
|
I think it's fair, and I will merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of VIP failover some connections (like mysql) can stuck
in retrying to connect and detect a dead connection. We
should probably make this failover to be detected faster then the
default value as suggested in [1]
[1] https://access.redhat.com/solutions/726753
Related-Bug: https://bugs.launchpad.net/kolla-ansible/+bug/1917068