-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing check options and missing checks #178
Add missing check options and missing checks #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
I am not having much time to tackle that this week, and I am on vacation after that.
So I will not be able to verify if everything is okay in terms of templating, and whether those options make sense.
There are two ways to go forward:
- Either I blindly trust you (as it seems good enough)
- Or we add a test for covering your use case, which actively tests the behaviour.
The former is the faster for everyone. However, it also means it could break in the future, as we are not testing this. I am not using this rserver part of the template myself and I never claimed to support it myself ;) (it's not documented).
So if you're willing to step up and add some tests, please tell me: I will then wait for the addition of the tests to merge this PR. Otherwise, I can merge now when the current tests are passing.
Please advice :)
The CI failure seems unrelated. I will push a fix, and rebase this. |
Sadly the fix will take more time than I expected, so I will not be able to fix this very soon. Sorry for the inconvenience. I will do my best to fix that in the next weeks. |
I am currently using some of this New options and i am confident about the others. |
I will have a look when I am back from vacation. And, yes, totally agree. It's just that the CI is borked because an upstream project for building images is broken. I will have to switch to another one. But that's another convo :) |
I am back from vacation. I will work on that today or tomorrow. |
Hello, It seems I don't have access to push to your branch. Do you mind either allowing me, or to rebase this PR from master branch, please? |
7540b78
to
c277eec
Compare
@evrardjp done :) |
Thanks. Go go github actions! |
needed some http options. ended adding all missing checks and check options