Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various optional parameters #185

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Conversation

mmetz-isa
Copy link

@mmetz-isa mmetz-isa commented Oct 9, 2021

Hi,

this PR makes the following optional keepalive parameters truly optional:

it also adds the following optional parameter:

This PR is based on top the 5.0.1 release tag.

As there is no CONTRIBUTE document or section in the README, please feel free to point out any adoptions required for merging this PR.

Copy link
Owner

@evrardjp evrardjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with those changes.

I think it would be nice to increase coverage of the minimum use case for vserver, as I don't use that, and it has been community contributed.

@evrardjp evrardjp merged commit 78fcf28 into evrardjp:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants