fix usage of deprecated include

[zerwes]

fixes:
[DEPRECATION WARNING]: "include" is deprecated, use include_tasks/import_tasks instead. This feature will be removed in version 2.16.

[evrardjp]

I think we're indeed in a place for which we don't support those old versions.
I always waited but I think it's time to move on ;)

[zerwes]

I do not think the import issue is requiring the support for ansible 2.9 needs to be dropped. include_tasks is available since 2.4 or 2.5...

The failing build message on github:

ERROR! couldn't resolve module/action 'community.docker.docker_container'. This often indicates a misspelling, missing collection, or incorrect module path.

IMHO this is not caused by some playbook code but is a molecule / OS setup problem ...

Sorry, I can not run the tests on my own, as on debian 11 the usual systemd images do not work (have the problem w/ other playbooks too)

fatal: [keepalived-bionic]: FAILED! => {"changed": false, "cmd": "systemctl daemon-reload && systemctl is-enabled keepalived.service", "delta": "0:00:00.003845", "end": "2022-01-19 16:57:11.358923", "failed_when_result": true, "msg": "non-zero return code", "rc": 1, "start": "2022-01-19 16:57:11.355078", "stderr": "Failed to connect to bus: No such file or directory", "stderr_lines": ["Failed to connect to bus: No such file or directory"], "stdout": "", "stdout_lines": []}

this is where the test fail on my system, but this has nothing to do with the changes made.

[evrardjp]

Hello.
You're 100% right, the code itself isn't the cause of a drop of 2.9.
Our testing framework is. I took the decision to move away from 2.9 because we would accrue tech debt, rather than reducing it.

please rebase your code, and the testing should work now.

[evrardjp]

@zerwes If there is an issue in testing with debian11, would you mind filing an issue for it, with the logs? We'll try to figure it out. It's probably a molecule thing again.

[evrardjp]

Commit message can be improved, but I won't be fussy about it. It's explaining the "what and why" enough.

[zerwes]

Thanks @evrardjp for the fixed test. All molecule tests pass after rebasing the PR branch.

[evrardjp]

I will bump the role on galaxy when another PR about template is merged.

[evrardjp]

Updated role was pushed to galaxy just a few minutes ago.