Commenting out unused variables for shellcheck compliance. #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evrardjp
previously requested changes
Dec 17, 2022
|
Sorry for the late answer. You can see the merge wasn't done due to failure in CI. Here is the PR of the CI change. #259 . When this is merged, I will rebase your code and run it again. If all goes well, it will be merged this week. |
evrardjp
dismissed
their stale review
Code was changed, change request should be dismissed
|
I just noticed that shellcheck isn't included in the tests, would you be okay to add it? Probably need to add somethign on the runners (.github/workflow/) and in the tox.ini (the shellcheck invocation). Edit: We can do so in a follow up PR. |
evrardjp
force-pushed
the
bugfix/notif_script
branch
from
fbda909
to
96db06c
Compare
evrardjp
force-pushed
the
bugfix/notif_script
branch
from
96db06c
to
afd5dff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this role being used in a project I'm collaborating on, where I want to run shellcheck on every single shellscript, so figured I'd patch this one and submit a PR.