Support absolute paths for SELinux modules #264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I like to keep forks of roles to a minimum and often refer to files (like your
keepalived_selinux_compile_rules
list) by absolute paths, usually based oninventory_dir
or similar. This isn't supported currently as it assumes each item in that list is a filename. This PR adds a new var for the basename which is used in most places. It has no effect on the default values and shouldn't be a breaking change for existing users as I expect it currently fails with relative paths like it does with absolute ones.I've also changed the check used for installing SELinux packages to check against the first element in
keepalived_selinux_compile_rules
instead of hardcodingkeepalived_ping
, which might be removed by a user overriding the list and thus missing the requirements for compiling modules.