Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented track_process #278

Merged
merged 2 commits into from
May 19, 2023

Conversation

zerwes
Copy link
Contributor

@zerwes zerwes commented Apr 18, 2023

see https://manpages.debian.org/unstable/keepalived/keepalived.conf.5.en.html for the advantages of using track_process instead of pgrep/pidof/killall and the likes.
and according to my open source slogan 'you need it, you implement it' here is a PR introducing the configuration options for track_process

Greetings
Klaus

Copy link
Owner

@evrardjp evrardjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry my comments were written a few weeks ago, but I didn't click send :(

templates/keepalived.conf.j2 Show resolved Hide resolved
templates/keepalived.conf.j2 Outdated Show resolved Hide resolved
Copy link
Owner

@evrardjp evrardjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - maps with what we discussed. A great addition to the role. I didn't test it manually.

@zerwes
Copy link
Contributor Author

zerwes commented May 16, 2023

I didn't test it manually.

I use the changed version meanwhile in 2 new cluster setups and migrated a few old from using track_script with pgrepor kill to track_process ... looks good to me, even if I did not test all params. In one case I have now a slightly different behavior regarding preempt, but this is a matter of the config and not of the role

@evrardjp
Copy link
Owner

Sure, I was just mentioning this for my records :D - My memory is bad.

@evrardjp evrardjp merged commit a73191c into evrardjp:master May 19, 2023
2 of 3 checks passed
@evrardjp
Copy link
Owner

@zerwes FYI the new release is in github and in galaxy.ansible.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants