Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let user to set his own DividerItemDecoration (separators) #90

Merged
merged 2 commits into from
Apr 27, 2018
Merged

Let user to set his own DividerItemDecoration (separators) #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48caa02
added interfaces for vertical dividers
sonique6784 Apr 27, 2018
2b007f7
allow user to overwrite createItemDecoration
sonique6784 Apr 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tableview/src/main/java/com/evrencoskun/tableview/ITableView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ public interface ITableView {
boolean isIgnoreSelectionColors();

boolean isShowHorizontalSeparators();

boolean isShowVerticalSeparators();

boolean isSortable();

Expand All @@ -74,6 +76,8 @@ public interface ITableView {
ColumnSortHandler getColumnSortHandler();

DividerItemDecoration getHorizontalItemDecoration();

DividerItemDecoration getVerticalItemDecoration();

SortState getSortingStatus(int column);

Expand Down
6 changes: 4 additions & 2 deletions tableview/src/main/java/com/evrencoskun/tableview/TableView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,7 @@ public void setShowHorizontalSeparators(boolean showSeparators) {
this.mShowHorizontalSeparators = showSeparators;
}

@Override
public boolean isShowVerticalSeparators() {
return mShowVerticalSeparators;
}
Expand Down Expand Up @@ -599,14 +600,15 @@ public DividerItemDecoration getHorizontalItemDecoration() {
return mHorizontalItemDecoration;
}

private DividerItemDecoration getVerticalItemDecoration() {
@Override
public DividerItemDecoration getVerticalItemDecoration() {
if (mVerticalItemDecoration == null) {
mVerticalItemDecoration = createItemDecoration(DividerItemDecoration.VERTICAL);
}
return mVerticalItemDecoration;
}

private DividerItemDecoration createItemDecoration(int orientation) {
protected DividerItemDecoration createItemDecoration(int orientation) {
Drawable divider = ContextCompat.getDrawable(getContext(), R.drawable.cell_line_divider);

// That means; There is a custom separator color from user.
Expand Down