Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature) 'Sıcaklık Değeri Elle de Girilebilecek' #21 solved. #32

Closed
wants to merge 1 commit into from
Closed

(feature) 'Sıcaklık Değeri Elle de Girilebilecek' #21 solved. #32

wants to merge 1 commit into from

Conversation

asiminnesli
Copy link

@asiminnesli asiminnesli commented Jan 18, 2022 •
edited
Loading

feature #21 (Sıcaklık Değeri Elle de Girilebilecek) solved.

Control List:

  • While checking, do not forget that the temperature bar is fixed between -273 - 7000.
  • When the temperature type (celsius, kelvin ...) changes, observe the conversion of the current temperature according to the new temperature (E.g. If it is converted to kelvin when it is 100 C, you should see 373)

note : It could be written cleaner by a more professional person who I'm not good at with vuejs.

@asiminnesli asiminnesli changed the title feature #21 solved. (feature) 'Sıcaklık Değeri Elle de Girilebilecek' #21 solved. Jan 18, 2022
cangencler
cangencler reviewed Jan 19, 2022
View reviewed changes
components/Slider.vue
this.$store.commit('SET_TEMPERATURE_TYPE', type)
console.log(Number(this.viewTemperature))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.log u silebiliriz.

@cagrimertbakirci cagrimertbakirci mentioned this pull request Jan 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cangencler cangencler cangencler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asiminnesli @cangencler