Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it ok that we have external dependancies? #107

Closed
abrekhov opened this issue Dec 28, 2021 · 1 comment
Closed

Is it ok that we have external dependancies? #107

abrekhov opened this issue Dec 28, 2021 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@abrekhov
Copy link

I see that inside internal/usecase/repo there are dependancies to pkg/postgres. Same thing with internal/controller/* ?

On the other hand I see in README that business logic must be clean from external dependancies.

Is it ok? Or it was about external projects at all?

@sashamelentyev sashamelentyev added the question Further information is requested label Dec 28, 2021
@neprja
Copy link
Contributor

neprja commented Jan 10, 2022

Business logic is a usecase, there should be no external dependencies.
The repository and controller can have external dependencies.

@neprja neprja closed this as completed Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants