Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement logout button #513

Closed
robigan opened this issue Feb 23, 2024 · 4 comments · Fixed by #522
Closed

Implement logout button #513

robigan opened this issue Feb 23, 2024 · 4 comments · Fixed by #522
Labels
enhancement New feature or request

Comments

@robigan
Copy link
Contributor

robigan commented Feb 23, 2024

The logout button only brings the user to the profile edit page. Without any logging out functionality working.
@evroon
Copy link
Owner

evroon commented Feb 23, 2024

Ah yeah I added it as a placeholder but never got around to actually implementing the logout logic.

@evroon evroon added the enhancement New feature or request label Feb 23, 2024
@evroon evroon changed the title Logout button doesn't work on Firefox 123.0 Implement logout button Feb 23, 2024
@robigan
Copy link
Contributor Author

robigan commented Feb 23, 2024

Then in that case, ye olde delete site cookies will do xD

@evroon
Copy link
Owner

evroon commented Feb 23, 2024

Haha yes indeed, but note the JWT is stored in localstorage, no cookies involved :)

@robigan
Copy link
Contributor Author

robigan commented Feb 23, 2024

Yeah, I'm aware but firefox has the one button that is called "Clear cookies and site data..."

@evroon evroon mentioned this issue Feb 24, 2024
Merged
evroon added a commit that referenced this issue Feb 24, 2024
@evroon
Fix logout button (#522)
34ea8e8 
fix #513

I also improved and optimized the rest of the navbar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix logout button evroon/bracket
2 participants
@evroon @robigan