Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check foreign keys belong to tournament #516

Merged
merged 8 commits into from
Feb 23, 2024

Conversation

evroon
Copy link
Owner

@evroon evroon commented Feb 23, 2024

Handles a security vulnerability where it's possible to link to columns of other tournaments, such as add players from another tournament to a team

@evroon evroon self-assigned this Feb 23, 2024
Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bracket ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 8:10pm

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 87.67123% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 92.36%. Comparing base (b395d14) to head (37cbb4b).

Files Patch % Lines
backend/bracket/sql/validation.py 88.23% 6 Missing ⚠️
backend/bracket/sql/players.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
- Coverage   92.41%   92.36%   -0.06%     
==========================================
  Files         105      106       +1     
  Lines        3572     3639      +67     
==========================================
+ Hits         3301     3361      +60     
- Misses        271      278       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evroon evroon merged commit d016e50 into master Feb 23, 2024
9 checks passed
@evroon evroon deleted the check-foreign-keys-belong-to-tournament branch February 23, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant