Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial version files #1

Merged
merged 36 commits into from Dec 20, 2018
Merged

Add initial version files #1

merged 36 commits into from Dec 20, 2018

Conversation

C-D-Lewis
Copy link
Contributor

@C-D-Lewis C-D-Lewis commented Dec 5, 2018 •
edited

  • Complete list of tests
  • Works for DL manipulation
  • Create demonstration test app
  • Be acceptable substitute for parser in gs1-digital-link-tools? (requires parser HTML outputs)

@C-D-Lewis
Add toJsonString and test
a9d9c6d
@C-D-Lewis
Add test-app example
b5be0e9
@C-D-Lewis
Add getTrace() and tests
a024a75
@C-D-Lewis
Refine getTrace()
a81076d
@C-D-Lewis
Improve test app to use trace
771b5d2
@C-D-Lewis
Better spacing when table is hidden
c70c052
@C-D-Lewis
Check identifier value is present before accepting URL
8b9f2f7
@C-D-Lewis
Update test-app, READMD.md
2af9765
@C-D-Lewis
Add test-app screenshot
b39f8b0
@C-D-Lewis
Rename toString to toUrlString
59ef114
@C-D-Lewis
Add info about unit test
17d34ef
@C-D-Lewis
Simplify test-app
429e621
@C-D-Lewis
Use factory function, add test cases
f2efac2
@C-D-Lewis
Update note about Symbol
a90978d
@C-D-Lewis
Rename to digital-link.js
91fea91
@C-D-Lewis
Add LICENSE
bfedc65
@C-D-Lewis
Simplify test-app
a59d203
@C-D-Lewis
Add testRule and supported Rules, plus tests
0e71d18
@C-D-Lewis
Add Utils.generateStatsHtml and Utils.generateTraceHtml, plus tests
c4d3ed6
@C-D-Lewis
Add, test, and document more HTML generation methods
9d879a5
@C-D-Lewis
Update README.md
8e9c898
@C-D-Lewis
Add link to digital-link.evrythng.com
a691b92
@C-D-Lewis C-D-Lewis changed the title Add initial draft version files Add initial version files Dec 19, 2018
domguinard
domguinard approved these changes Dec 19, 2018
View reviewed changes
Copy link
Member

@domguinard domguinard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me, tests passing now. Corrected tiny inconsistencies in the readme. We are good to push it live!

@C-D-Lewis C-D-Lewis merged commit e055cf3 into master Dec 20, 2018
@C-D-Lewis C-D-Lewis deleted the develop branch December 20, 2018 09:23
domguinard added a commit that referenced this pull request Jul 18, 2019
@domguinard
Merge pull request #1 from evrythng/master
bda2083 
Including support for compression
domguinard added a commit that referenced this pull request Jul 18, 2019
@domguinard
Merge pull request #8 from gs1/master
7ec1470 
Merge pull request #1 from evrythng/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domguinard domguinard domguinard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@C-D-Lewis @domguinard