Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#165 To-Do View (for unscheduled plans) #182

Merged
merged 3 commits into from Mar 18, 2019
Merged

#165 To-Do View (for unscheduled plans) #182

merged 3 commits into from Mar 18, 2019

Conversation

gzinck
Copy link
Collaborator

@gzinck gzinck commented Mar 17, 2019

This new view displays all events which do not have any assigned start date. It is sorted from high to low priority.

Copy link
Owner

@evscott evscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - unless the console.log being left is intentional, this looks good to be merged once it's removed.

Also, something appears to be up with Circle-ci. It's waiting to begin a process, this usually happens when something has changed within it's .yml file, but it doesn't look like you've altered that file and you even encountered a linting failure earlier with this pr?

src/components/trip_view/cal/ToDoView.js Show resolved Hide resolved
src/redux/getters/getEvents.js Outdated Show resolved Hide resolved
src/components/trip_view/cal/ToDoView.js Show resolved Hide resolved
@gzinck
Copy link
Collaborator Author

gzinck commented Mar 18, 2019

Not sure what was up with CircleCI, but it passed the latest commit (with only 1 line changed)!

Copy link
Owner

@evscott evscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge away!

@evscott
Copy link
Owner

evscott commented Mar 18, 2019

Not sure what was up with CircleCI, but it passed the latest commit (with only 1 line changed)!

Bizarre.

@gzinck gzinck merged commit 02ab1fd into master Mar 18, 2019
@gzinck gzinck deleted the #165 branch March 18, 2019 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants