#179 #207
Merged
#179 #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Login Page, Issue with passing properties
Login Page, Issue with passing properties
… must be added later.
… must be added later.
# Conflicts: # src/components/dashboard/jumbotron/OngoingJumbotron.js # src/components/dashboard/jumbotron/OngoingJumbotronContainer.js # src/components/dashboard/jumbotron/UpcomingJumbotron.js
# Conflicts: # src/components/dashboard/jumbotron/OngoingJumbotron.js # src/components/dashboard/jumbotron/OngoingJumbotronContainer.js # src/components/dashboard/jumbotron/UpcomingJumbotron.js
evscott
reviewed
Apr 2, 2019
| @@ -0,0 +1,4 @@ | |||
| .countdown-elem{ | |||
| padding: 0 20px; | |||
|
|
|||
There was a problem hiding this comment.
This blank space should be removed.
evscott
reviewed
Apr 2, 2019
| */ | ||
| getTimeDiv() { | ||
| let currTrip = this.props.currTripInfo.trip; | ||
| if (currTrip === null) { |
There was a problem hiding this comment.
Is there a purpose for
let currTrip = this.props.currTripInfo.trip;
if (currTrip === null) {
return;
}
it appears as though it is never being used?
There was a problem hiding this comment.
In order to access the trip_start variable, we need the trip to not be null.
morgankbender
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.