Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
shared/machine-pool: fix mkfs.btrfs checking
binary_is_good translates ENOENT to 0 See systemd@85eca92e#diff-bcad68c477b6651521e880c40b7a9b40R813
- Loading branch information
c3b0e5a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your fix is correct, but I think it'd be better to simply change mkfs_exists to return -ENOENT. The place you are changing is the only user, and it just looks stupid to change the error code twice.
c3b0e5a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe.
But systemd@85eca92e
c3b0e5a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.