Skip to content

Commit

Permalink
firebase: Remove cleanUruls again
Browse files Browse the repository at this point in the history
Remove cleanUruls again, firstly it causes a 301 redirect when trying to
access the .html pages which is where all the links point which is also
useful for local or basic fileserve deployment. Secondly it breaks anchor
navigation within the site and causes a brief flicker of the sidebar is the
redirected site is loaded from the firebase server again:
when loading /spec an anchor link to /spec.html#map causes a full page reload.

Lastly, Evy is about learning and understanding all things code. Making use of
some firebase setting to avoid typing ".html" makes things less clear.
  • Loading branch information
juliaogris committed May 20, 2024
1 parent e22bdab commit 19cfbfa
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
9 changes: 3 additions & 6 deletions firebase/firebase.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,18 +34,15 @@
},
{
"target": "discord",
"public": "public/discord",
"cleanUrls": true
"public": "public/discord"
},
{
"target": "docs",
"public": "public/docs",
"cleanUrls": true
"public": "public/docs"
},
{
"target": "learn",
"public": "public/learn",
"cleanUrls": true
"public": "public/learn"
},
{
"target": "play",
Expand Down
3 changes: 0 additions & 3 deletions frontend/docs/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,6 @@ function normalizedHref() {
if (href.endsWith("/")) {
href = href + "index.html"
}
if (!href.endsWith(".html")) {
href = href + ".html"
}
return href + hash
}

Expand Down

0 comments on commit 19cfbfa

Please sign in to comment.