Skip to content

Commit

Permalink
💥 parser: Improve error message for variadic (#352)
Browse files Browse the repository at this point in the history
Improve error message for invalid variadic parameters, where a non-variadic
and a variadic parameters are combined. Previously it said

	invalid variadic parameter, must be used with single type

now it says:

	variadic parameter cannot be used with other parameters

Pull-request: #352
  • Loading branch information
juliaogris committed May 20, 2024
1 parent 5506e7a commit a368eff
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/parser/parser.go
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ func (p *parser) parseFuncDefSignature() *FuncDefStmt {
fd.Params = nil
fd.VariadicParamType = &Type{Name: ARRAY, Sub: fd.VariadicParam.Type()}
} else {
p.appendError("invalid variadic parameter, must be used with single type")
p.appendError("variadic parameter cannot be used with other parameters")
}
}
p.assertEOL()
Expand Down
17 changes: 17 additions & 0 deletions pkg/parser/parser_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,23 @@ fox 1 2 3`,
}
}

func TestVariadicFuncDefErr(t *testing.T) {
inputs := map[string]string{
`
func fox n:num nums:num...
print n nums
end
fox 1 2 3`: "line 2 column 27: variadic parameter cannot be used with other parameters",
}
for input, wantErr := range inputs {
parser := newParser(input, testBuiltins())
assertParseError(t, parser, input)
gotErr := parser.errors.Truncate(1)
assert.Equal(t, wantErr, gotErr.Error())
}
}

func TestReturn(t *testing.T) {
inputs := []string{
`
Expand Down

0 comments on commit a368eff

Please sign in to comment.