docsite: Fix various minor annoyances #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
firebase-deployment for 950f4c8 |
Fix broken anchor navigation for reloads and using back and forwards browser buttons. I've tried to bisect this and all I could find was that anchor navigation seems to be broken the moment you put your main content inside a css grid or flexbox display container.
Remove cleanUruls again, firstly it causes a 301 redirect when trying to access the .html pages which is where all the links point which is also useful for local or basic fileserve deployment. Secondly it breaks anchor navigation within the site and causes a brief flicker of the sidebar is the redirected site is loaded from the firebase server again: when loading /spec an anchor link to /spec.html#map causes a full page reload. Lastly, Evy is about learning and understanding all things code. Making use of some firebase setting to avoid typing ".html" makes things less clear.
Fix preventReloadOnSelfLink function, which forgot to strip the hash if the initial load included it.
Fix anchor margin on page reload where in Chrome the heading had no padding towards the top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preventReloadOnSelfLinkfunction