code review

classes/condition.php

@@ -40,7 +40,6 @@
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class condition extends \core_availability\condition {
-
     /** @var string coursecompleted 0 => No, 1 => Yes */
     protected $coursecompleted;
 
@@ -56,7 +55,7 @@ public function __construct($structure) {
         } else if (is_string($structure->id)) {
             $this->coursecompleted = $structure->id;
         } else {
-            throw new coding_exception('Invalid value for course completed condition');
+            new coding_exception('Invalid value for course completed condition');
         }
     }
 
@@ -134,7 +133,7 @@ public function get_description($full, $not, info $info) {
      * @return string Text representation of parameters
      */
     protected function get_debug_string() {
-        return $this->coursecompleted ? '#' . 'True' : 'False';
+        return get_string($this->coursecompleted ? 'true' : 'false', 'mod_quiz');
     }
 
     /**
@@ -162,7 +161,8 @@ public function filter_user_list(
         array $users,
         $not,
         \core_availability\info $info,
-        \core_availability\capability_checker $checker) {
+        \core_availability\capability_checker $checker
+    ) {
 
         global $DB;
 
@@ -186,15 +186,15 @@ public function filter_user_list(
             // Always include users with access to completion report.
             if (array_key_exists($id, $adusers)) {
                 $result[$id] = $user;
-                continue;
-            }
-            // Other users are included or not based on course completion.
-            $allow = array_key_exists($id, $compusers);
-            if ($not) {
-                $allow = !$allow;
-            }
-            if ($allow) {
-                $result[$id] = $user;
+            } else {
+                // Other users are included or not based on course completion.
+                $allow = array_key_exists($id, $compusers);
+                if ($not) {
+                    $allow = !$allow;
+                }
+                if ($allow) {
+                    $result[$id] = $user;
+                }
             }
         }
         return $result;

classes/frontend.php

@@ -39,8 +39,6 @@
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class frontend extends \core_availability\frontend {
-
-
     /**
      * Decides whether this plugin should be available in a given course. The
      * plugin can do this depending on course or system settings.

classes/privacy/provider.php

@@ -34,7 +34,6 @@
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class provider implements \core_privacy\local\metadata\null_provider {
-
     /**
      * Get the language string identifier with the component's language
      * file to explain why this plugin stores no data.

tests/advanced_test.php

@@ -41,7 +41,6 @@
  * @coversDefaultClass \availability_coursecompleted
  */
 final class advanced_test extends \advanced_testcase {
-
     /** @var stdClass course. */
     private $course;
 
@@ -208,7 +207,9 @@ public function test_page(): void {
         $this->assertFalse($cond->is_available_for_all());
         $this->assertFalse($cond->update_dependency_id(null, 1, 2));
         $this->assertEquals($cond->__toString(), '{coursecompleted:False}');
-        $this->assertEquals($cond->get_standalone_description(true, true, $info),
-            'Not available unless: You completed this course.');
+        $this->assertEquals(
+            $cond->get_standalone_description(true, true, $info),
+            'Not available unless: You completed this course.'
+        );
     }
 }

tests/basic_test.php

@@ -41,7 +41,6 @@
  * @coversDefaultClass \availability_coursecompleted
  */
 final class basic_test extends \basic_testcase {
-
     /**
      * Tests the constructor including error conditions.
      * @covers \availability_coursecompleted\condition

tests/behat/behat_availability_coursecompleted.php

@@ -30,7 +30,7 @@
 require_once(__DIR__ . '/../../../../../lib/behat/behat_base.php');
 // @codeCoverageIgnoreEnd
 
-use Behat\Mink\Exception\ElementNotFoundException as ElementNotFoundException;
+use Behat\Mink\Exception\ElementNotFoundException;
 
 /**
  * Step definitions related to mark user complete.
@@ -41,7 +41,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class behat_availability_coursecompleted extends behat_base {
-
     /**
      * Complete user in a course
      * @Then /^I mark course "(?P<course>[^"]*)" completed for user "(?P<user>[^"]*)"$/

tests/behat_test.php

@@ -35,7 +35,6 @@
  * @coversDefaultClass \availability_coursecompleted
  */
 final class behat_test extends \advanced_testcase {
-
     /**
      * Test behat funcs
      * @covers \behat_availability_coursecompleted

tests/coverage.php

@@ -25,6 +25,14 @@
 
 defined('MOODLE_INTERNAL') || die();
 
+/**
+ * Unit tests for the coursecompleted condition.
+ *
+ * @package   availability_coursecompleted
+ * @copyright 2022 iplusacademy (www.iplusacademy.org)
+ * @author    Renaat Debleu <info@eWallah.net>
+ * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
 return new class extends phpunit_coverage_info {
     /** @var array The list of folders relative to the plugin root to include in coverage generation. */
     protected $includelistfolders = ['classes'];

tests/privacy/privacy_test.php

@@ -38,7 +38,6 @@
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 final class privacy_test extends provider_testcase {
-
     /**
      * Test returning metadata.
      * @covers \availability_coursecompleted\privacy\provider