Ewallah issue #4

[ewallah]

Improve integration with Moodle Workplace Certificates

[coveralls]

coverage: 100.0% (+2.5%) from 97.5% when pulling 9518449 on ewallah-issue-4 into 08410a3 on main.

[marinaglancy]

I did not test it but is it possible that a student does not have any records in the 'course_completions' table at all?
In this case the SQL for the "not completed" case would be wrong.

In fact, you check $not again below, so you kind of inverse it?

[ewallah]

Why would it be wrong?

The function only removes users (https://github.com/moodle/moodle/blob/master/availability/classes/tree.php#L298), so if there are no records in the course_completions table, they will be removed if the $not parameter is true.

This second $not is needed, first I collect the users who did complete the course or did not (based on what is stored in the condition), next I apply the $not, the same way it happens with availability group:
first: if ($this->groupid)
next: if($not)