Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EEI: transfer() method and simplification of selfDestruct() #113

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

EEI: transfer() method and simplification of selfDestruct() #113

wants to merge 2 commits into from

Conversation

chfast
Copy link
Collaborator

@chfast chfast commented Jul 25, 2018 •
edited

Resolves #98.

@lrettig
Copy link
Member

lrettig commented Jul 25, 2018

I had a conversation with (I believe) @Arachnid at Ethereum Magicians where I used this method as an example of Ewasm departing from full EVM compatibility, and he indicated that it's dangerous and that the existing transfer mechanics are the way they are for a reason--something to do with the danger of transferring to a contract which is not designed to accept ETH, thus acting as a black hole for funds. It might be interesting to have that conversation here.

@chfast
Copy link
Collaborator Author

chfast commented Jul 25, 2018

I agree. This method is only needed for evm2wasm. I want it to be properly designed, then we can disable it in "pure ewasm" configurations.

@axic
Copy link
Member

axic commented Jul 30, 2018

Wouldn't you want to propose this PR in conjunction with changing selfDestruct at the same time?

@axic axic added this to Proposed in Revision 4 Jul 30, 2018
@chfast
Copy link
Collaborator Author

chfast commented Jul 30, 2018

Wouldn't you want to propose this PR in conjunction with changing selfDestruct at the same time?

I can, but I wanted to propose a single change per PR for easier review.

@chfast chfast changed the title EEI: transfer() method EEI: transfer() method and simplification of selfDestruct() Jul 31, 2018
@chfast
Copy link
Collaborator Author

chfast commented Jul 31, 2018

Added selfDestruct() changes.

@chfast chfast mentioned this pull request Jul 31, 2018
Open
@axic axic removed this from Proposed in Revision 4 Aug 16, 2018
@axic axic added this to Proposed in Revision 5 Aug 16, 2018
@chfast
Copy link
Collaborator Author

chfast commented Aug 22, 2018

Rebased.

@axic axic removed this from Proposed in Revision 5 Nov 26, 2018
@axic axic added this to In progress in Revision 6 via automation Nov 26, 2018
@egroge
Copy link

egroge commented Sep 8, 2020

Hello, is this transfer method likely to be merged into eWASM? If not, what is the accepted way to transfer money between accounts in eWASM? Any links or explanations on this would be appreciated as I have not been able to find much about it so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
EEI (environment interface)
Projects
Revision 6
  
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not transfer ETH with selfDestruct
4 participants
@chfast @lrettig @axic @egroge