Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

less whitespace #65

Closed
wants to merge 1 commit into from
Closed

less whitespace #65

wants to merge 1 commit into from

Conversation

cdetrio
Copy link
Contributor

@cdetrio cdetrio commented Dec 28, 2017

separate whitespace changes from #48

@axic
Copy link
Member

axic commented Jan 8, 2018

What is the benefit of this? I actually like it more spread for readability.

@cdetrio
Copy link
Contributor Author

cdetrio commented Jan 8, 2018

its to make the async PR more readable (after a rebase), so the only changes would be lines around the changed methods

@axic
Copy link
Member

axic commented Jan 21, 2018

I see, I'd rather remove those whitespace changes from the async PR.

@cdetrio cdetrio closed this Jan 21, 2018
@axic axic deleted the less-whitespace branch January 23, 2018 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants