sync kernel #5
Open
sync kernel #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdetrio
force-pushed
the
sync-kernel
branch
6 times, most recently
from
026e3d1
to
c451a7f
Compare
axic
reviewed
Jan 21, 2018
| _call (gasHigh, gasLow, addressOffset, valueOffset, dataOffset, dataLength, resultOffset, resultLength, cbIndex) { | ||
| // _call (gasHigh, gasLow, addressOffset, valueOffset, dataOffset, dataLength, resultOffset, resultLength, cbIndex) { | ||
| // cbIndex was for async method | ||
| _call (gasHigh, gasLow, addressOffset, valueOffset, dataOffset, dataLength, resultOffset, resultLength) { |
There was a problem hiding this comment.
Does this needs to have an underscore prefix because call is a restricted keyword in es6?
axic
reviewed
Jan 21, 2018
| @@ -59,6 +59,7 @@ module.exports = class Interface { | |||
| 'getBlockGasLimit', | |||
| 'log', | |||
| 'create', | |||
| '_call', | |||
There was a problem hiding this comment.
I don't think this will make call available to contracts. is there some code somewhere removing the underscore prefix?
axic
reviewed
Jan 21, 2018
| @@ -579,6 +580,7 @@ module.exports = class Interface { | |||
| storageStore (keyOffset, valueOffset, cbIndex) { | |||
There was a problem hiding this comment.
The cbIndex parameter should be removed from all of the async methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.