Remove outdated content and add some tiny remarks in the README #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
reviewed
Aug 28, 2018
| @@ -1,6 +1,6 @@ | |||
| # Hera  | |||
|
|
|||
| Hera is an [ewasm] virtual machine implemented in C++ conforming to [EVMC]. | |||
| Hera is an [ewasm] (revision 4) virtual machine implemented in C++ conforming to [EVMC] ABIv5. | |||
There was a problem hiding this comment.
I'd refer to it just as EVMC 5.
There was a problem hiding this comment.
I'm not sure, I think that is not enough. Perhaps EVMC v5? Still looks to me that EVMC ABIv5 is the most expressive one.
There was a problem hiding this comment.
But how do you know which versions it refers to?
There was a problem hiding this comment.
Should have an explanatory section in the EVMC documentation which explains the ABI version, how it relates to EVMC versioning and the preferred way to refer to a given "ABI version".
There was a problem hiding this comment.
Created an issue on the evmc repo to track this.
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
=======================================
Coverage 67.66% 67.66%
=======================================
Files 8 8
Lines 1036 1036
Branches 135 135
=======================================
Hits 701 701
Misses 303 303
Partials 32 32 |
chfast
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.