Skip to content

Commit

Permalink
Merge pull request #268 from eweitz/refine-custom-organism-handling
Browse files Browse the repository at this point in the history
Throw warning instead of error for unknown / custom organism
  • Loading branch information
eweitz committed Apr 30, 2021
2 parents 19699e2 + 35e73bc commit b641189
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/js/services/organisms.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ function getTaxidFromEutils(orgName, ideo) {
return d3.json(taxonomySearch).then(function(data) {
var idlist = data.esearchresult.idlist;
if (idlist.length === 0) {
throw Error(
var warning =
'Organism "' + orgName + '" is generally unknown; it was not found ' +
'in the NCBI Taxonomy database. If you did not intend to specify a ' +
'novel or custom taxon, then try using the organism\'s ' +
'scientific name, e.g. Homo sapiens or Arabidopsis thaliana.'
);
'scientific name, e.g. Homo sapiens or Arabidopsis thaliana.';
throw warning;
} else {
taxid = data.esearchresult.idlist[0];
return [orgName, taxid];
Expand Down Expand Up @@ -211,8 +211,8 @@ function populateNonNativeOrg(orgs, ideo) {
};

Object.assign(ideo.organisms, augmentedOrganismMetadata);
}, function(errorMessage) {
console.info(errorMessage);
}, function(warning) {
console.warn(warning);
var customMetadata = {
scientificName: org,
commonName: org,
Expand Down

0 comments on commit b641189

Please sign in to comment.