Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexbar module is broken #1407

Closed
adomingues opened this issue Apr 7, 2021 · 6 comments
Closed

Flexbar module is broken #1407

adomingues opened this issue Apr 7, 2021 · 6 comments
Labels
bug: module Bug in a MultiQC module

Comments

@adomingues
Copy link

Description of bug:

A warning message is generated after running multiqc:

Oops! The 'flexbar' MultiQC module broke..

MultiQC Error log:

multiqc -o ${PRJ_RESULTS}/multiqc .
[INFO   ]         multiqc : This is MultiQC v1.10.1
[INFO   ]         multiqc : Template    : default
[INFO   ]         multiqc : Searching   : /mnt/projects/genomics/projects/RBM20_clip/results
Searching   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 550/550  
[INFO   ]            star : Found 8 reports
[INFO   ]         bowtie2 : Found 3 reports
[ERROR  ]         multiqc : Oops! The 'flexbar' MultiQC module broke... 
  Please copy the following traceback and report it at https://github.com/ewels/MultiQC/issues 
  If possible, please include a log file that triggers the error - the last file found was:
    ./processed_reads/flexbar/raw_rbm20_6sg_NH_HM_04.log
============================================================
Module flexbar raised an exception: Traceback (most recent call last):
  File "/mnt/genomics/envs/multiqc/lib/python3.6/site-packages/multiqc/multiqc.py", line 594, in run
    output = mod()
  File "/mnt/genomics/envs/multiqc/lib/python3.6/site-packages/multiqc/modules/flexbar/flexbar.py", line 31, in __init__
    self.parse_flexbar(f)
  File "/mnt/genomics/envs/multiqc/lib/python3.6/site-packages/multiqc/modules/flexbar/flexbar.py", line 94, in parse_flexbar
    _save_data(parsed_data)
  File "/mnt/genomics/envs/multiqc/lib/python3.6/site-packages/multiqc/modules/flexbar/flexbar.py", line 64, in _save_data
    float(parsed_data["removed_bases"]) / float(parsed_data["processed_bases"])
ZeroDivisionError: float division by zero
============================================================
[INFO   ]          fastqc : Found 10 reports
[INFO   ]         multiqc : Compressing plot data
[INFO   ]         multiqc : Report      : ../../../../../genomics/projects/results/multiqc/multiqc_report.html
[INFO   ]         multiqc : Data        : ../../../../../genomics/projects/results/multiqc/multiqc_data
[INFO   ]         multiqc : MultiQC complete

File that triggers the error:

MultiQC run details (please complete the following):

  • Command used to run MultiQC: multiqc -o ${PRJ_RESULTS}/multiqc .
  • MultiQC Version: MultiQC v1.10.1
  • Operating System: Ubuntu 20.04
  • Python Version: Python 3.6.13
  • Method of MultiQC installation: conda

Additional context

@ewels ewels added bug: module Bug in a MultiQC module waiting: example data Needs example data before we can proceed labels Apr 7, 2021
@ewels
Copy link
Member

ewels commented Apr 7, 2021

Thanks for reporting! Please can you zip and attach ./processed_reads/flexbar/raw_rbm20_6sg_NH_HM_04.log so that I can try to replicate this to find the problem 😄

@ewels
Copy link
Member

ewels commented Apr 7, 2021

(I guess that this sample has zero reads in it)

@adomingues
Copy link
Author

You are right - not reads in it. I think this was a reliq from a previously failed test. Attached nonetheless.

raw_rbm20_6sg_NH_HM_04.zip

@ewels
Copy link
Member

ewels commented Apr 8, 2021

Thanks! Yes still good to handle it rather than crashing 👍🏻

@ewels ewels removed the waiting: example data Needs example data before we can proceed label Apr 8, 2021
ewels added a commit to MultiQC/test-data that referenced this issue Apr 8, 2021
@ewels ewels closed this as completed in 4d3fd1c Apr 8, 2021
@ewels
Copy link
Member

ewels commented Apr 8, 2021

Ok, should be fixed in the development version now, done in 4d3fd1c. It just sets the % removed bases to 0 if there are zero total reads.

Let me know if you hit any other problems. Thanks for reporting!

@adomingues
Copy link
Author

Cheers!

vladsavelyev pushed a commit to vladsavelyev/MultiQC_TestData that referenced this issue Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: module Bug in a MultiQC module
Projects
None yet
Development

No branches or pull requests

2 participants