Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porechop bar charts result in error when no adapters found by tool #1850

Closed
jfy133 opened this issue Jan 31, 2023 · 2 comments
Closed

Porechop bar charts result in error when no adapters found by tool #1850

jfy133 opened this issue Jan 31, 2023 · 2 comments
Assignees
Labels
bug: module Bug in a MultiQC module

Comments

@jfy133
Copy link
Contributor

jfy133 commented Jan 31, 2023

The recently added porechop module was only tested on a log file from a file that did in fact have adapters. We've just learnt that when there are no adapters, Porechop does not report the log file sections used in the current MultiQC module (resulting in a 'no data found' error in MultiQC).

The MultiQC module should be updated to either skip the add_section call when the corresponding values are not found, or could have a custom HTML div + .alert that explains why (suggested by @ewels )

I will assign this to @sofstam and myself

@ewels ewels added waiting: example data Needs example data before we can proceed bug: module Bug in a MultiQC module labels Jan 31, 2023
@jfy133
Copy link
Contributor Author

jfy133 commented Jan 31, 2023

Porechop_NoAdaptersFound.log

test data to go on the repo when we get to this :)

@ewels ewels removed the waiting: example data Needs example data before we can proceed label Feb 1, 2023
@ewels ewels closed this as completed in 0bb3f82 Feb 8, 2023
ewels added a commit to MultiQC/test-data that referenced this issue Feb 8, 2023
@ewels
Copy link
Member

ewels commented Feb 8, 2023

@jfy133 - done ✅ 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: module Bug in a MultiQC module
Projects
None yet
Development

No branches or pull requests

2 participants