Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastQC: fix UnicodeDecodeError parsing fastqc_data.txt (try latin-1 or fail gracefully) #2024

Merged
merged 2 commits into from Sep 3, 2023

Conversation

vladsavelyev
Copy link
Member

Fixes #1941

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍🏻

@ewels ewels merged commit fc87b71 into master Sep 3, 2023
10 checks passed
@ewels ewels deleted the fastqc-unicode branch September 3, 2023 19:54
@ewels
Copy link
Member

ewels commented Sep 3, 2023

Oops, just realised that I merged this without a changelog entry.

We should check the (now nice and clean) git history to manually curate the changelog before release. Make sure we didn't miss anything.

@vladsavelyev
Copy link
Member Author

Yeah, really easy to forget to add a change log entry 😅 Gotta automate it.

Will add a line for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FastQC: UnicodeDecodeError with weird sequence characters
2 participants