New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Pangolin module #1458
Merged
Merged
New Pangolin module #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewels
reviewed
Jun 23, 2021
ewels
reviewed
Jun 23, 2021
multiqc/modules/pangolin/pangolin.py
Outdated
) | ||
|
||
def parse_pangolin_log(self, fh): | ||
contents = csv.DictReader(fh["f"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in a core Python library? I don't think I've ever used this before 🤯
Learn something new every day! 😆
ewels
reviewed
Jun 23, 2021
Thanks for all the tips! I'll have to look through all the changes you've made and give the docs a more thorough read. |
ewels
force-pushed
the
master
branch
2 times, most recently
from
June 24, 2021 15:11
3e19e54
to
9f00c19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote new module Pangolin module, according to specification given in #1454. It might be that there are too many columns in the generated table, since I didn't know what was essential and non-essential to the report.
CHANGELOG.md
has been updated--lint
flag)docs/README.md
is updated with link to belowdocs/modulename.md
is createdself.add_section
)