Salmon reports library info to General Stats table #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewels
changed the title
|
Thanks a lot for the contribution - and sorry that it took that long to review this PR. Finally going through the backlog! Merged with master and slightly cleaned, looks good to me :) |
vladsavelyev
approved these changes
Dec 15, 2023
ewels
approved these changes
Dec 16, 2023
| "max": 1.0, | ||
| "scale": "YlGn", | ||
| }, | ||
| "strand_mapping_bias": { |
There was a problem hiding this comment.
I don't think that we have any test data with this key yet..
There was a problem hiding this comment.
(Not a blocker, but would be nice to get some if we can).
Co-authored-by: Phil Ewels <phil.ewels@seqera.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdhas been updatedSalmon module reports the following to the General Stats table:
libary_typesfromaux_info/meta_info.json(hidden if all values are the same across all samples)compatible_fragment_ratioandstrand_mapping_biasfrom 'lib_format_counts.json'