Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module ngsbits #1553

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Module ngsbits #1553

wants to merge 13 commits into from

Conversation

jakobmatthes
Copy link

@jakobmatthes jakobmatthes commented Sep 17, 2021

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md has been updated
  • There is example tool output for tools in the https://github.com/ewels/MultiQC_TestData repository or attached to this PR
  • Code is tested and works locally (including with --lint flag)
  • docs/README.md is updated with link to below
  • docs/modulename.md is created
  • Everything that can be represented with a plot instead of a table is a plot
    • here tables are better to check correlation
  • Report sections have a description and help text (with self.add_section)
  • There aren't any huge tables with > 6 columns (explain reasoning if so)
    • columns are closely related and easy to read, despite >6
  • Each table column has a different colour scale to its neighbour, which relates to the data (eg. if high numbers are bad, they're red)
  • Module does not do any significant computational work

@gartician gartician mentioned this pull request Oct 11, 2021
11 tasks
@ewels
Copy link
Member

ewels commented Nov 15, 2021

Please pull in upstream changes - this will hopefully help the CI tests. I can't do it for you sorry as this PR comes from an organisation fork rather than a personal account (and so I don't have permissions to push to your PR branch).

@vladsavelyev vladsavelyev mentioned this pull request Dec 14, 2023
6 tasks
@vladsavelyev
Copy link
Member

@jakobmatthes - thank you so much for the contribution, and sorry it took so long to review! I created a new PR with comments #2231 as I can't push directly into your fork, and I wanted to merge with the master branch. Feel free to continue pushing into the new PR if you are still up to working on the module :) It would be great to have it merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants