Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify length field in general statistics #1567

Merged
merged 3 commits into from
Nov 9, 2021

Conversation

schorlton
Copy link
Contributor

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md has been updated

When both FastQC and QUAST reports are included in MultiQC, both tools include a field with the header Length in the general statistics table. On first glance, this is very confusing for users. Here we just clarify which length they're presenting. Also fixed a bug where QUAST size suffixes can change.

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, agreed - in hindsight probably a little too aggressive on the short column titles. Agree that this is clearer 👍🏻

Thanks!

multiqc/modules/quast/quast.py Show resolved Hide resolved
@ewels ewels merged commit 3cd7222 into MultiQC:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants