-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fastp PF. #1587
Fix fastp PF. #1587
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested before and after the change and I can see no effect in the report, as expected. So I'm happy 👍🏻
Please just add a line to the CHANGELOG.md
file saying that you fixed a bug in the Fastp module with a link to the issue. Hopefully should be clear when you see how other changelog items are written.
Thanks!
Phil
Note (as this is your first ever PR) - no need to close the pull request or anything. Just commit + push the requested change to your branch and the pull request will automatically update with the additional changes. |
1 commit for the actual bugfix, 5 commits for the changelog oneliner 😆 This is how it goes sometimes... |
CHANGELOG.md
has been updated