Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fastp PF. #1587

Merged
merged 6 commits into from
Nov 15, 2021
Merged

Fix fastp PF. #1587

merged 6 commits into from
Nov 15, 2021

Conversation

g-pacheco
Copy link
Contributor

@g-pacheco g-pacheco commented Nov 15, 2021

Screenshot (266)

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md has been updated

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested before and after the change and I can see no effect in the report, as expected. So I'm happy 👍🏻

Please just add a line to the CHANGELOG.md file saying that you fixed a bug in the Fastp module with a link to the issue. Hopefully should be clear when you see how other changelog items are written.

Thanks!

Phil

@ewels
Copy link
Member

ewels commented Nov 15, 2021

Note (as this is your first ever PR) - no need to close the pull request or anything. Just commit + push the requested change to your branch and the pull request will automatically update with the additional changes.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@ewels ewels enabled auto-merge November 15, 2021 22:48
@ewels
Copy link
Member

ewels commented Nov 15, 2021

1 commit for the actual bugfix, 5 commits for the changelog oneliner 😆 This is how it goes sometimes...

@ewels ewels merged commit a259b08 into MultiQC:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants