Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicate heatmap for kraken #1779

Merged
merged 6 commits into from Nov 26, 2022
Merged

Conversation

jchorl
Copy link
Contributor

@jchorl jchorl commented Oct 13, 2022

The kraken module takes the top 5 taxons and shows duplication across samples.

The problem is when some samples don't include those taxons. The heatmap "collapses left" because of how the dict is turned into a list:
Screenshot 2022-10-13 at 14-49-41 Screenshot 2022-10-12 at 16-20-36 MultiQC Report png (PNG Image 590 × 508 pixels)

This means the duplication amount shown on the second row is actually for the wrong taxon!

Really, we should fill in None (or 0?) when a taxon isn't present in a sample. After fixing:
Screenshot 2022-10-13 at 15-52-49 MultiQC Report

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md has been updated

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, improves the MultiQC_TestData too:

image

to this:

image

@ewels
Copy link
Member

ewels commented Nov 26, 2022

In fact, I don't think that this heatmap needs to be square.. Tacked a minor config improvement on to your PR 👍🏻

@ewels ewels merged commit 3b74a38 into MultiQC:master Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants