Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Qualimap: add additional entries for qualimap when region stats present #1798

Merged
merged 4 commits into from Nov 30, 2022

Conversation

jfy133
Copy link
Contributor

@jfy133 jfy133 commented Nov 11, 2022

The current Qualimap module does not pick up statistics relevant for when stats on particular regions are generated via a bed file. This PR adds support for displaying these statistics in the general stats table (when the parrticular entries are present)

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md has been updated

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just not sure why you need the second separate set of regexes.

multiqc/modules/qualimap/QM_BamQC.py Outdated Show resolved Hide resolved
multiqc/modules/qualimap/QM_BamQC.py Outdated Show resolved Hide resolved
multiqc/modules/qualimap/QM_BamQC.py Outdated Show resolved Hide resolved
multiqc/modules/qualimap/QM_BamQC.py Outdated Show resolved Hide resolved
multiqc/modules/qualimap/QM_BamQC.py Outdated Show resolved Hide resolved
ewels and others added 2 commits November 26, 2022 12:27
Co-authored-by: Phil Ewels <phil.ewels@seqera.io>
Also: Fix randomly aggressive Snippy module parsing bug
@ewels
Copy link
Member

ewels commented Nov 30, 2022

Thanks both! I refactored the code a bit to make it a little cleaner / more robust. I also stumbled across a bug in the Snippy module so snuck a fix for that into this PR as well.

@ewels ewels merged commit e185c85 into MultiQC:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants