-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new module Bakta #1959
new module Bakta #1959
Conversation
Co-authored-by: Vlad Savelyev <vladislav.sav@gmail.com>
Thank you for the review @vladsavelyev! Please check if I resolved the merge conflict for the CHANGELOG.md and README.md correctly. |
multiqc/modules/bakta/bakta.py
Outdated
"title": "# contigs", | ||
"description": "Number of contigs", | ||
"min": 0, | ||
"format": "{:i}%", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it's not a percentage? Also, I don't think {:i} is a recognised format string. At least it doesn't seem to work, as numbers are displayed in the table as string (you can tell that by the lack of thousand groups separators!). I'll change them to "{:,d}"
if that's okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@louperelo - thanks for responding to the review quickly! Last time I didn't complete it, just left a few quick suggestions 😅 Now it's done. I mostly merged my suggestions directly into the branch, hope it's okay. Here is what I changed:
- fixed the format strings to
"format": "{:,d}"
- table colors - I tried to make them match similar metrics in the QUAST module, plus added a
shared_key: gene_count
for the CDS count to make the number scale comparable with QUAST - got rid of spaces in the metric keys - it's not a problem for MultiQC, but theoretically might be some downstream tools that might use MultiQC output
- iterating over
f["contents_lines"]
to avoid extra splitting - in search patterns, removed
num_lines: 26
to make it more future-proof
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Bakta
is a tool for rapid and standardized annotation of bacterial genomes, MAGs and plasmids. We are usingBakta
as one of the annotation tool options innf-core/funcscan
and would like to include its output in the pipelines MultiQC report.CHANGELOG.md
has been updated--lint
flag)docs/README.md
is updated with link to belowdocs/modulename.md
is createdself.add_section
)