Don't sys.exit from run() function #2055
Conversation
|
Need to double check that I haven't missed any other |
|
Scooped up a couple of others, some remain but I think that we can tackle those during wider refactoring. Hopefully this PR replaces the ones within Still needs testing, running each of the edge cases where these trigger, to make sure I haven't screwed up.
|
| @@ -981,7 +981,7 @@ def __rich_measure__(self, console: rich.console.Console, options: rich.console. | |||
| logger.error("Output directory {} already exists.".format(config.plots_dir)) | |||
| logger.info("Use -f or --force to overwrite existing reports") | |||
| shutil.rmtree(tmp_dir) | |||
| sys.exit(1) | |||
| return {"report": report, "config": config, "sys_exit_code": 1} | |||
There was a problem hiding this comment.
I guess because of these lines it also should never happen, unless a folder was created by another process.
https://github.com/ewels/MultiQC/blob/5f21841908b3771d9775a97521faf0a9737ad5d6/multiqc/multiqc.py#L933-L934
Simulated that, works fine
There was a problem hiding this comment.
Yes, you might be right there. I suspect that this code predates the rotating suffix thing being added. In which case, we can presumably just delete this chunk of code.
|
Feel free to merge when you're happy @vladsavelyev 👍🏻 |
Noticed that we have a stray
sys.exit()call in therun()function. This should be removed for usage in interactive environments.Not checked thoroughly yet, so needs sanity checking / testing before merge.